More robusts tests for requirements_file and conda_file #4394
Conversation
| }) | ||
| @mock.patch('readthedocs.projects.models.Project.checkout_path') | ||
| def test_conda_with_cofig(self, checkout_path): | ||
| base_path = tempfile.mkdtemp() |
There was a problem hiding this comment.
I wasn't able to reuse the apply_fs function (only works with pytest) or fake_paths as the check is very strict.
| @@ -40,14 +44,30 @@ def inner(path=None, env_config=None): | |||
| return inner | |||
|
|
|||
|
|
|||
| @mock.patch('readthedocs.doc_builder.config.load_config') | |||
There was a problem hiding this comment.
I have to remove the class level mock and only used it in some methods
| """ | ||
| Creates a readthedocs configuration file with name | ||
| ``file_name`` in ``base_path``. If ``base_path`` is not given | ||
| a temporal directory is created. |
There was a problem hiding this comment.
nit: not to change now, but just to consider that PEP257 (https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings) says that we need one summary line, a blank line, and a more elaborate description.
I know that you love following PEPs ;)
NOTE: this is checked automatically by one of our linters and it will fail in that case.
|
|
||
| full_requirements_file = path.join(base_path, requirements_file) | ||
| with open(full_requirements_file, 'w') as f: | ||
| f.write('pip') |
There was a problem hiding this comment.
Do we need to create this file at all for the test?
There was a problem hiding this comment.
Yeah, the validation is very strict, and it checks that the file exists, I wasn't able to mock this one. But I'm using pytest for our new tests, and we don't need to use this hacks anymore
stsewd
force-pushed
the
better-tests-for-config-integration
branch
from
2703a5b to
773cbff
Compare
|
Rebased and updated |
stsewd
force-pushed
the
better-tests-for-config-integration
branch
from
773cbff to
d8c173c
Compare
stsewd
force-pushed
the
better-tests-for-config-integration
branch
from
d8c173c to
0774e23
Compare
Previous tests were mocking the
load_configfunction, now we are testing it for realRelated to #4379