Check for 'options' in update_repos command #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Jul 16, 2018
| @@ -57,7 +57,8 @@ def handle(self, *args, **options): | |||
| record = options['record'] | |||
| force = options['force'] | |||
| version = options['version'] | |||
| if args: | |||
|
|
|||
| if options: | |||
There was a problem hiding this comment.
Options already have some keys (record, force, etc). I think we want to skip this and just do for slug in options.get('slugs', []): ...
Fix bug introduced in #4345
humitos
force-pushed
the
humitos/command/update_repos
branch
from
c935ae8 to
0c17b42
Compare
|
Merging since it's not a big change and it's annoying when importing project to debug :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #4345 (comment)