Use PATHs to call clear_artifacts #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a list of PATHs Instead of using a ``Version.pk`` when calling `clear_artifacts`. This is because in the ``Version.delete`` method, the Version object is removed immediately after broadcasting the ``clear_artifacts`` task and that could produce a race condition. With this change, we calculate all the PATHs needed _before_ broadcasting the task and _before_ deleting the object from the database.
humitos
commented
Jun 25, 2018
| remove_dir(version.project.get_production_media_path( | ||
| type_='htmlzip', version_slug=version.slug)) | ||
|
|
||
| def clear_artifacts(paths): |
There was a problem hiding this comment.
I kept the name, but it could be changed to remove_dirs. Although, it won't reflect the specific usage that we give to this task.
agjohnson
approved these changes
Jun 25, 2018
I grepped the code with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a list of PATHs Instead of using a
Version.pkwhen callingclear_artifacts. This is because in theVersion.deletemethod, the Version object is removed immediately after broadcasting theclear_artifactstask and that could produce a race condition.With this change, we calculate all the PATHs needed before broadcasting the task and before deleting the object from the database.