Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page detailing ad blocking #4244

Merged
merged 2 commits into from
Jun 18, 2018

Conversation

davidfischer
Copy link
Contributor

  • Creates a good page for the ad block nag to link to
  • Document about going ad-free
  • Some advertisers have asked about this
  • Stats on ad blocking are interesting - we should publish ours

Important

This moves the ethical-advertising.rst and advertising-details.rst documents into an advertising/ folder. After merging this, we should setup redirects.

- Creates a good page for the ad block nag to link to
- Document about going ad-free
- Some advertisers have asked about this
- Stats on ad blocking are interesting - we should publish ours
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally 👍 with a few nits on RST syntax & marketing wording. I think we should really nail how we feel about "subscribing" or "supporting" us, instead of "donating".

Advertising is the single largest source of funding for Read the Docs.
To keep our operations sustainable, we ask that you either
:ref:`allow our Ethical Ads <advertising/ad-blocking:Allowing Ethical Ads>`
or :ref:`go ad-free <advertising/ad-blocking:Going ad-free>` by donating.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike using the word donate, since they are getting value from their money in not seeing ads. I'd like to come up with better verbiage here; perhaps "by becoming a contributing member" or "supporting member" or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we call them "supporters" in the database and in the site footer, let's use the phrase "becoming a supporter". Since we call Gold "becoming a gold member" I don't want to have to differentiate between a "Gold Member" and a "Supporting Member" or a "Contributing Member".

Let's just use "Gold Member" and "Supporter".

@@ -121,7 +121,7 @@ Analytics

Analytics are a sensitive enough issue that they require their own section.
In the spirit of full transparency, Read the Docs uses Google Analytics (GA).
We go into a bit of detail on our use of GA in our :doc:`privacy-policy`.
We go into a bit of detail on our use of GA in our :doc:`../privacy-policy`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a absolute link so this doesn't break in the future /privacy-policy

.. Updated: June 2018

- Serve over **35 million pages** of documentation a month
- Serve over **2 TB** of documentation a month
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number is much higher. We did 40TB last month.

- Use "supporter" instead of donate
- Use absolute links
- 2TB -> 40TB
@davidfischer
Copy link
Contributor Author

I made the suggested changes.

@ericholscher
Copy link
Member

Looks great!

@davidfischer davidfischer merged commit 9a4c459 into master Jun 18, 2018
@davidfischer
Copy link
Contributor Author

Merged, built and the redirects were added.

@stsewd stsewd deleted the davidfischer/ad-blocking-details-docs branch August 15, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants