-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow staying logged in for longer #4236
Merged
ericholscher
merged 5 commits into
master
from
davidfischer/advertising-preferences-tweak
Jun 22, 2018
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0e5f4b1
Allow staying logged in for longer
davidfischer 3f3358f
Remove extending session cookie
davidfischer ef99a49
Update session settings
davidfischer debde2f
Remove session expiry variable that isn't used
davidfischer d7f8b6a
Don't set the production session engine here
davidfischer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,9 +55,14 @@ class CommunityBaseSettings(Settings): | |
DEFAULT_FROM_EMAIL = '[email protected]' | ||
SERVER_EMAIL = DEFAULT_FROM_EMAIL | ||
|
||
# Cookies | ||
# Sessions | ||
SESSION_COOKIE_DOMAIN = 'readthedocs.org' | ||
SESSION_COOKIE_HTTPONLY = True | ||
SESSION_COOKIE_AGE = 30 * 24 * 60 * 60 # 30 days | ||
SESSION_ENGINE = 'django.contrib.sessions.backends.signed_cookies' | ||
SESSION_SAVE_EVERY_REQUEST = True | ||
|
||
# CSRF | ||
CSRF_COOKIE_HTTPONLY = True | ||
CSRF_COOKIE_AGE = 30 * 24 * 60 * 60 | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to use signed cookies, don't we want to remove
django.contrib.sessions
fromINSTALLED_APPS
?. What I understand from the documentation it's only used for database-cookies.https://docs.djangoproject.com/en/1.11/topics/http/sessions/#using-database-backed-sessions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of actually taking this change out and making this a setting that is set in the production settings rather than in the base settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are advantages to signed cookies but they aren't huge and they are what's holding this up due to the complications with the corporate site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the
SESSION_ENGINE
setting here. If we decide to change the productionSESSION_ENGINE
, we'll do that in the production settings file. This will ensure that anyone taking our code and using it don't have aSESSION_ENGINE
change unless they want one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. 👍