-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare code for custo mkdocs.yaml location #4184
Conversation
I need to do this for the others builders and use the |
Some changes depend on #4041 |
OK, I tested this manually with two projects (mkdocs and #3249 (comment)) it works as expected, going to block this due #4041 |
Updated and tested, just to note that this feature doesn't work as the initially reported issue because of https://www.mkdocs.org/about/release-notes/#stricter-directory-validation. this is more useful for people that have a layout like:
So, people need to install a previous version of mkdocs for it to works in a structure like the above. For that reason, I decided to no implement that. Is this PR still useful? Yes, with this we can support the |
Looks good. 👍 |
This fix #3249Our docs mention that we search for the
mkdocs.yaml
inside thedocs
directory, but that's a lie, we only search in the root of the project. Also, this will prepare our code for themkdocs
key of the new yaml file.