Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove silly Beta labels from the Privacy & Python Version selectors #4142

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

ericholscher
Copy link
Member

This has been shipped for years,
and we should remove the beta labels :)

This has been shipped for years,
and we should remove the beta labels :)
@ericholscher ericholscher requested a review from a team May 24, 2018 16:19
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good :)

I suppose that you may want to run the proper migration since the help text has changed. This has confused many contributors in the past months.

Anyway, this is 👍

@ericholscher
Copy link
Member Author

@humitos what do you think of this solution for all these silly help_text migrations? https://stackoverflow.com/a/39801321

@ericholscher ericholscher merged commit ba901b8 into master Jun 7, 2018
@ericholscher
Copy link
Member Author

Putting this on the pile of silly non-DB migration changes. Need to fix them in another way.

@stsewd stsewd deleted the remove-beta branch August 15, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants