-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gold Member marketing #4063
Merged
davidfischer
merged 3 commits into
readthedocs:master
from
davidfischer:update-rtd-gold-marketing
May 22, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
readthedocs/templates/profiles/private/advertising_profile.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
{% extends "profiles/base_profile_edit.html" %} | ||
|
||
{% load i18n %} | ||
|
||
{% block title %}{% trans "Set advertising preferences" %}{% endblock %} | ||
|
||
{% block profile-admin-advertising %}active{% endblock %} | ||
|
||
{% block edit_content_header %} {% trans "Set advertising preferences" %} {% endblock %} | ||
|
||
{% block edit_content %} | ||
<p> | ||
{% blocktrans %} | ||
Read the Docs is an open source project. | ||
In order to maintain service, we rely on both the | ||
support of our users, and from sponsor support. | ||
{% endblocktrans %} | ||
</p> | ||
|
||
<p> | ||
{% blocktrans %} | ||
For more details on advertising on Read the Docs | ||
including the privacy protections we have in place for users | ||
and community advertising we run on behalf of the open source community, | ||
see <a href="https://docs.readthedocs.io/en/latest/ethical-advertising.html">our documentation</a>. | ||
{% endblocktrans %} | ||
</p> | ||
|
||
{% if request.user.gold.exists or request.user.goldonce.exists %} | ||
<p> | ||
{% blocktrans %} | ||
<strong>Note:</strong> | ||
Since you are a Gold Member or donor, you <strong>will not</strong> see advertising as long as you are logged-in. | ||
Thank you for supporting Read the Docs. | ||
{% endblocktrans%} | ||
</p> | ||
{% else %} | ||
<p> | ||
{% url "gold_detail" as gold_detail %} | ||
{% blocktrans %} | ||
You may remove ads completely by becoming a <a href="{{ gold_detail }}">Gold member to Read the Docs</a>. | ||
{% endblocktrans %} | ||
</p> | ||
{% endif %} | ||
|
||
<form method="POST" action="."> | ||
{% csrf_token %} | ||
{{ form.as_p }} | ||
<input type="submit" name="submit" value="{% trans "Update advertisement preference" %}" id="submit"/> | ||
</form> | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like these other parts of the page are just blabbing in an awkward way also. I'm almost tempted to just remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give it a read and see if there's anything that should be removed. I tried to remove anything inaccurate already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think everything around domains can be deleted once we get Lets Encrypt support. I don't quite think I'll delete that yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would LE support change our infra cost for domains? If anything, it would increase the overhead we have for each domain we serve, managing the certs, etc.