Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bookmark app lint failures #3969

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Fix bookmark app lint failures #3969

merged 1 commit into from
Apr 18, 2018

Conversation

davidfischer
Copy link
Contributor

No description provided.

@davidfischer davidfischer requested a review from humitos April 18, 2018 17:26
humitos
humitos approved these changes Apr 18, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the errors are only in the bookmarks app, which is something that we are trying to remove completely :(

@davidfischer
Copy link
Contributor Author

I'll be happy when it's gone (#3663) but until then we shouldn't have the tests fail.

@davidfischer davidfischer merged commit 66fe4bd into readthedocs:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfischer @humitos