-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page redirect preview #3811
Conversation
It included '//' - this ought to fix readthedocs#2380.
Can you rebase against master? New rules for js were added since the original PR :) |
mmm, the changes are on the template, so doesn't matter. But I think the new rules for js require using |
✅ |
Does this need anything else to be considered for merge? Can it be considered reviewed as this is the result of the review in #2711? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vidartf for you time working on this!
Superseeds #2711. Closes #2380.