Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3718: Added date to changelog #3727

Closed
wants to merge 5 commits into from
Closed

#3718: Added date to changelog #3727

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65fc8d5
#3718: Added date to changelog
irkartik Mar 4, 2018
c750b5f
Update setup.cfg
irkartik Mar 4, 2018
5b25840
deleted local changelog
irkartik Mar 4, 2018
e7acb0f
#3718: DELETE CHANGELOG AND LOOK OF CHANGELOG
irkartik Mar 4, 2018
54c6c5c
#3718: fixed merge issue
irkartik Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,48 @@
Version build - March 04, 2018
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no need to add the changelog here, but looks great how is generated now :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you... But hope I didn't messed up anything in my first attempt :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, just revert the version number, delete the changelog file and take a look to my other comment. Then I think it's ready to get merged! Thanks for you interest on collaborating.

-------------

* `@mbarnes-sb <http://github.com/mbarnes-sb>`_: Build #90721 Failed (`#3721 <https://github.com/rtfd/readthedocs.org/issues/3721>`_)
* `@mxbi <http://github.com/mxbi>`_: problem with Read the Docs: Build 6826343 failed (`#3713 <https://github.com/rtfd/readthedocs.org/issues/3713>`_)
* `@algorys <http://github.com/algorys>`_: Build 6825626 failed (`#3711 <https://github.com/rtfd/readthedocs.org/issues/3711>`_)
* `@keflavich <http://github.com/keflavich>`_: Build 6824799 failed (`#3710 <https://github.com/rtfd/readthedocs.org/issues/3710>`_)
* `@justb4 <http://github.com/justb4>`_: Build 6824762 fails (`#3709 <https://github.com/rtfd/readthedocs.org/issues/3709>`_)
* `@PoslavskySV <http://github.com/PoslavskySV>`_: Build 6824044 failed (`#3707 <https://github.com/rtfd/readthedocs.org/issues/3707>`_)
* `@bmerry <http://github.com/bmerry>`_: Build failing with no logs (`#3705 <https://github.com/rtfd/readthedocs.org/issues/3705>`_)
* `@agjohnson <http://github.com/agjohnson>`_: Add argument to skip errorlist through knockout on common form (`#3704 <https://github.com/rtfd/readthedocs.org/pull/3704>`_)
* `@ajatprabha <http://github.com/ajatprabha>`_: Fixed #3701: added closing tag for div element (`#3702 <https://github.com/rtfd/readthedocs.org/pull/3702>`_)
* `@ajatprabha <http://github.com/ajatprabha>`_: div tag not closed project_dashboard.html (`#3701 <https://github.com/rtfd/readthedocs.org/issues/3701>`_)
* `@willingc <http://github.com/willingc>`_: Failed build (`#3700 <https://github.com/rtfd/readthedocs.org/issues/3700>`_)
* `@philrz <http://github.com/philrz>`_: Build failure (`#3692 <https://github.com/rtfd/readthedocs.org/issues/3692>`_)
* `@bansalnitish <http://github.com/bansalnitish>`_: Removed ScrollBar in Firefox (`#3686 <https://github.com/rtfd/readthedocs.org/pull/3686>`_)
* `@ericholscher <http://github.com/ericholscher>`_: Show the project slug in the project admin (to make it more explicit what project is what) (`#3681 <https://github.com/rtfd/readthedocs.org/pull/3681>`_)
* `@sda399 <http://github.com/sda399>`_: :ref: target not highlighted in navigation bar (`#3679 <https://github.com/rtfd/readthedocs.org/issues/3679>`_)
* `@vmalloc <http://github.com/vmalloc>`_: RTD build does not install dependencies properly (`#3678 <https://github.com/rtfd/readthedocs.org/issues/3678>`_)
* `@humitos <http://github.com/humitos>`_: Upgrade django-taggit to 0.22.2 (`#3667 <https://github.com/rtfd/readthedocs.org/pull/3667>`_)
* `@MissSheyni <http://github.com/MissSheyni>`_: +989031964735 (`#3662 <https://github.com/rtfd/readthedocs.org/issues/3662>`_)
* `@stsewd <http://github.com/stsewd>`_: Check for submodules (`#3661 <https://github.com/rtfd/readthedocs.org/pull/3661>`_)
* `@BenCook28 <http://github.com/BenCook28>`_: Unable to Set Pin Through Either Mac Bridge or Chrome Extension, Bootloader Mode (`#3660 <https://github.com/rtfd/readthedocs.org/issues/3660>`_)
* `@Adul-Denature <http://github.com/Adul-Denature>`_: Obat Sipilis Herbal Merk De Nature Resep Dokter (`#3658 <https://github.com/rtfd/readthedocs.org/issues/3658>`_)
* `@agjohnson <http://github.com/agjohnson>`_: Hotfix for adding logging call back into project sync task (`#3657 <https://github.com/rtfd/readthedocs.org/pull/3657>`_)
* `@agjohnson <http://github.com/agjohnson>`_: Fix issue with missing setting in oauth SyncRepo task (`#3656 <https://github.com/rtfd/readthedocs.org/pull/3656>`_)
* `@agjohnson <http://github.com/agjohnson>`_: AttributeError: 'SyncRepositoryTask' object has no attribute '_log' (`#3655 <https://github.com/rtfd/readthedocs.org/issues/3655>`_)
* `@ericholscher <http://github.com/ericholscher>`_: Remove error logging that isn't an error. (`#3650 <https://github.com/rtfd/readthedocs.org/pull/3650>`_)
* `@aasis21 <http://github.com/aasis21>`_: formatting buttons in edit project text editor (`#3633 <https://github.com/rtfd/readthedocs.org/pull/3633>`_)
* `@mithro <http://github.com/mithro>`_: Rich text editor on settings page is broken on Chrome & Firefox (`#3629 <https://github.com/rtfd/readthedocs.org/issues/3629>`_)
* `@mithro <http://github.com/mithro>`_: SSL certificate used on bam.nr-data.net will be distrusted soon (`#3628 <https://github.com/rtfd/readthedocs.org/issues/3628>`_)
* `@agjohnson <http://github.com/agjohnson>`_: Conditionally do git submodule operations (`#3627 <https://github.com/rtfd/readthedocs.org/issues/3627>`_)
* `@agjohnson <http://github.com/agjohnson>`_: Start testing Sphinx 1.7.0 (`#3598 <https://github.com/rtfd/readthedocs.org/pull/3598>`_)
* `@veenamj <http://github.com/veenamj>`_: Is it possible to add a simple feedback form on each page of my documentation project as we have copyright info now? (`#3568 <https://github.com/rtfd/readthedocs.org/issues/3568>`_)
* `@axnsan12 <http://github.com/axnsan12>`_: sphinx viewcode fails intermittently during build (`#3411 <https://github.com/rtfd/readthedocs.org/issues/3411>`_)
* `@madskinner <http://github.com/madskinner>`_: There was a problem with Read the Docs while building your documentation. (`#3359 <https://github.com/rtfd/readthedocs.org/issues/3359>`_)
* `@veenamj <http://github.com/veenamj>`_: Builds don't run because of setup.py - issue is happening suddenly (`#3296 <https://github.com/rtfd/readthedocs.org/issues/3296>`_)
* `@madskinner <http://github.com/madskinner>`_: Sphinx build failed with unknown error. (`#3276 <https://github.com/rtfd/readthedocs.org/issues/3276>`_)
* `@agjohnson <http://github.com/agjohnson>`_: Support opt in to latest build image, automate wiping of environment (`#3190 <https://github.com/rtfd/readthedocs.org/issues/3190>`_)
* `@carukc <http://github.com/carukc>`_: How do you create bookmarks? (`#2173 <https://github.com/rtfd/readthedocs.org/issues/2173>`_)
* `@takluyver <http://github.com/takluyver>`_: Installing conda package ncurses fails with 'placeholder too short' (`#1902 <https://github.com/rtfd/readthedocs.org/issues/1902>`_)
* `@sergiopasra <http://github.com/sergiopasra>`_: Badges don't work with "protected" projects (`#1690 <https://github.com/rtfd/readthedocs.org/issues/1690>`_)
* `@astrofrog <http://github.com/astrofrog>`_: Matplotlib backend should be forced to Agg (`#1195 <https://github.com/rtfd/readthedocs.org/issues/1195>`_)
* `@espdev <http://github.com/espdev>`_: Haystack SearchFieldError: ... has an empty model_attr 'version' and doesn't allow a default or null value (`#827 <https://github.com/rtfd/readthedocs.org/issues/827>`_)

Version 2.2.1
-------------

Expand Down
2 changes: 1 addition & 1 deletion contrib/changelog.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{header}}
{{header}} - {{date}}
{{toHeader header "-"}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toHeader must receive the same above text, so that they have the same width

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do i need to re submit the code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do the requested changes on this same branch and do push again, GitHub will update the PR automatically :). Let me know if you need more help.


{{#issues}} * `@{{user.login}} <http://github.com/{{user.login}}>`_: {{title}} (`#{{number}} <{{html_url}}>`_)
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = readthedocs
version = 2.2.1
version = build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the implication in changing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't changed it.. It got automatically changed when i ran invoke prepare build ... Looks like I had to pass version number in place of build.

license = MIT
description = Read the Docs builds and hosts documentation
author = Read the Docs, Inc
Expand Down