Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for adding logging call back into project sync task #3657

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Hotfix for adding logging call back into project sync task #3657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3323b2c
Hotfix for adding logging call back into project sync task
agjohnson Feb 22, 2018
6e6da87
Minor lint fixed
humitos Feb 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions readthedocs/projects/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,15 @@ def sync_repo(self):
except Exception:
log.exception('Unknown Sync Versions Exception')

# TODO this is duplicated in the classes below, and this should be
# refactored out anyways, as calling from the method removes the original
# caller from logging.
def _log(self, msg):
log.info(LOG_TEMPLATE
.format(project=self.project.slug,
version=self.version.slug,
msg=msg))


class SyncRepositoryTask(SyncRepositoryMixin, Task):

Expand Down