Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error logging that isn't an error. #3650

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Remove error logging that isn't an error. #3650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/builds/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def commit_name(self):

# If we came that far it's not a special version nor a branch or tag.
# Therefore just return the identifier to make a safe guess.
log.error('TODO: Raise an exception here. Testing what cases it happens')
log.debug('TODO: Raise an exception here. Testing what cases it happens')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups! I introduced this for future research and I never did it :/

return self.identifier

def get_absolute_url(self):
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/core/views/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def redirect_page_with_filename(request, project, subproject, filename): # pyli
def _serve_401(request, project):
res = render(request, '401.html')
res.status_code = 401
log.error('Unauthorized access to {0} documentation'.format(project.slug))
log.debug('Unauthorized access to {0} documentation'.format(project.slug))
return res


Expand Down
2 changes: 1 addition & 1 deletion readthedocs/projects/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ def update_search(version_pk, commit, delete_non_commit_files=True):
if version.project.is_type_sphinx:
page_list = process_all_json_files(version, build_dir=False)
else:
log.error('Unknown documentation type: %s',
log.debug('Unknown documentation type: %s',
version.project.documentation_type)
return

Expand Down