-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Git on prod #3615
Update Git on prod #3615
Conversation
This is required to fix Edit button on annotated tags readthedocs#3441 (reverted fix)
I wish this is as easy as it was to update git in our production instances. Our builders are currently running 14.04, so "update git in prod" actually means "fully re-deploy an entire stack of servers". We're going to be transitioning away from Rackspace soon, so that upgrade will take place as part of our server migrations. |
@ericholscher from https://docs.readthedocs.io/en/latest/development/buildenvironments.html it looks like those builders are Docker images, so changing them to 16.04 should be easy. |
Git is currently run outside of docker in some cases, for reasons :) |
@ericholscher are there any security reasons to keep the workflow undocumented? =) |
Just lack of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think we can merge this already.
Servers where upgraded to 16.04 and they are running git 2.7.4
at the moment.
I'm fixing the edit button problem using gitpython on #4052 |
Will go ahead and merge this, as I believe our git is upgraded in production. |
This is required to fix Edit button on annotated tags
#3441 (reverted fix)