Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pylint to 1.7.5 and fix docstring styling #3408

Merged
merged 7 commits into from
Dec 18, 2017
Merged

Pin pylint to 1.7.5 and fix docstring styling #3408

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8edf582
Fix pytlint to 1.7.5 since 1.8.0 has problems with pylint-django
humitos Dec 15, 2017
63a96d7
Ignore unused pep257 errors
humitos Dec 16, 2017
4d10f2e
Fix D213 using docformatter
humitos Dec 16, 2017
e720959
Ignore pydocstyle sections handling
humitos Dec 16, 2017
10fa100
Rephrase "This" in docstrings
humitos Dec 16, 2017
5b240bc
Minor docstring style fix
humitos Dec 16, 2017
5630fad
Allow some specific exceptions
humitos Dec 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions requirements/lint.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
-r pip.txt
maxcdn
astroid
pylint
# prospector==0.12.6 currently has issues with pydocstyle
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unppined this because I didn't find any error related with pydocstyle. Besides, I think the new version works as it should.

prospector==0.12.5

# pylint 1.8.0 is having problems:
# File "/home/humitos/.pyenv/versions/2.7.14/envs/pylint/lib/python2.7/site-packages/pylint_django/plugin.py", line 22, in register
# start = name_checker.config.const_rgx.pattern[:-2]
# AttributeError: 'NoneType' object has no attribute 'pattern
pylint==1.7.5

prospector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't prospector also be pinned?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Maybe".

Read my comment below in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm torn on whether we pin these or not. We are fighting broken testing dependencies at least twice a month now. Pinning does help avoid this, but I don't think there is a strong reason to pin otherwise.

pylint-django
pyflakes