-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CDN code to external abstraction #2091
Conversation
This adds a signal for listening as an external application, purging can be performed on a project basis there.
This should remove the CDN code from inside RTD, as well. |
Forgot that, updated. |
Guessing this is blocked on deployment as well? Looks good otherwise. |
It shouldn't on the community site at least, as there aren't any cdn users configured |
Ah, True. |
👍 on merging re: conversation above. |
It seems like the |
Need to get back to this and rebase, will need to double check that the pieces we need are in the extension + operations provisioning. Marked as blocking for now |
This is now unblocked and should be cleaned up. |
@agjohnson anything specifically that needs to be cleaned up? I don't believe we currently have an CDN users, so this would be a good time to get it merged. |
@agjohnson I'd be +1 on merging this now since we don't have any current CDN users, and we can confirm it works on the next setup we do. |
@agjohnson is there anything else we need to do here? It seems that we remove the |
This adds a signal for listening as an external application, purging can be
performed on a project basis there.