Fix theme js on third party themes #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
force-pushed
the
add-call-to-theme-js
branch
from
612d1a4 to
717faa9
Compare
|
👍 |
ericholscher
added a commit
that referenced
this pull request
Sep 23, 2015
Fix theme js on third party themes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing implied call to instantiate the theme javascript that was
removed in favor of an explicit call. This adds the call back to the footer
html template, where the flyout block is added to third party themes. Also
fixes a bug with promos that was triggered without the normal nav.
A more permanent fix will come with the next theme release and resolution of readthedocs/sphinx_rtd_theme#250