Require admin status in project to add it as a subproject #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -253,6 +253,9 @@ def sync_supported_versions(self): | |||
| verbose_name__in=supported).update(supported=False) | |||
| self.versions.filter(verbose_name=LATEST_VERBOSE_NAME).update(supported=True) | |||
|
|
|||
| def user_is_admin(self, user): | |||
There was a problem hiding this comment.
We are trying to unify all this logic in one place, which is in the privacy app. This should be routing that logic through there, at least.
There was a problem hiding this comment.
Great, didn't know about that! That's integrated now.
It was previously possible to add subprojects without beeing admin of them. It should be required to be a admin. Otherwise people end up getting incorporated into a project without knowing it or beeing asked. Related to #1122
Also adding tests on removing subprojects
Based on feedback: #1503 (comment)
gregmuellegger
force-pushed
the
validate-subproject-admin
branch
from
9e99576 to
c9550d7
Compare
|
I rebased on the latest master (which changed all the imports) and integrated feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you didn't need to be a admin in the subproject to add it as a
project. That way your project could end up as a subproject in project you
don't know about without you being asked for permission.
That has lead to situations were you added a subproject by accident but were
not able to remove it again from your own project since removing it required
admin permissions on the subproject. This PR removes the "am I admin" on the
subproject when removing it.
I added the django-dynamic-fixture library for easy fixture generation. I know
we already have bambooboy for this in the project. But I have issues with this
library. I will propose something related to that later.
Fixes #1122.
Fixes #1341.