-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run FileTreeDiff indexer on all versions in dev #11873
base: main
Are you sure you want to change the base?
Conversation
This allows easier support for working on this locally, and runs it against all active verisons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we don't have different behavior for these on development than in production. It gets hard to debug when something doesn't work as expected.
It's useful to have to file the full workflow in development as well, so we know how it works on production as well.
@humitos it seems really hard to setup GH webhooks and full integration locally, including having a "local" instance pushing live build status to PRs, so I think it makes sense here? |
That's a good point. I forgot how I was testing this, but definitely not setting up GH webhooks nor pushing live build status to PRs. I think I marked a |
Yea, just seems nice to have a good way to turn this on locally. You still need to enable it in the Addons Config, but I think having a good test of it is useful, and makes dev easier. But I can also just do a quick note in the docs/code about a workflow for enabling dev if we think that's better than baking it into the code. |
Would you like to add an environment variable to be able to turn this on/off so we can test production behavior locally when needed? |
This allows easier support for working on this locally,
and runs it against all active verisons.