Addons: API response for tooltips #11746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial `addons.tooltips` object with basic data for testing purposes.
stsewd
reviewed
Nov 6, 2024
stsewd
approved these changes
Nov 7, 2024
Comment on lines
+229
to
+240
| linkpreviews_doctool_name = models.CharField( | ||
| choices=LINKPREVIEWS_DOCTOOL_NAME_CHOICES, | ||
| null=True, | ||
| blank=True, | ||
| max_length=128, | ||
| ) | ||
| linkpreviews_doctool_version = models.CharField( | ||
| null=True, | ||
| blank=True, | ||
| max_length=128, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Are we planning to auto-fill this via the build config or something? Feels odd that users would have to define this in multiple places. In particular a version number feels super weird to have to keep updated, and definitely won't be modified by the user in any ongoing way.
ericholscher
approved these changes
Nov 12, 2024
|
Will this start showing for everyone, or are we not shipping the user facing UI here yet? |
|
Link previews are gonna be disabled by default. At least for now. We can change that in the future if we consider. The UI is at readthedocs/ext-theme#521, so we can decide merge it or not. |
|
Will plan to merge this, and test it via the admin with no user-facing UI to start. |
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Dec 5, 2024
 Required by readthedocs/addons#379 Required by readthedocs/readthedocs.org#11746 Closes readthedocs/addons#239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial
addons.tooltipsobject with basic data for testing purposes.We will also want to add here:
Required by readthedocs/addons#422
Closes readthedocs/addons#239