Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file: add support for latest aliases #11081

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 31, 2024

@stsewd stsewd requested review from a team as code owners January 31, 2024 00:01
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 🎉

I left some improvement suggestions on the documentation trying to make those sentences more clear. Besides, we need to change the name of the Ubuntu latest to ubuntu-lts-latest as we discussed.

I just want to make sure we are all on the same page regarding this change before merging.

docs/user/config-file/v2.rst Outdated Show resolved Hide resolved
Comment on lines 282 to 283
The ``ubuntu-latest-lts`` option refers to the latest LTS version of Ubuntu available on Read the Docs,
not the latest LTS version available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is confusing. In particular the final part saying "not the latest LTS version available"

Suggested change
The ``ubuntu-latest-lts`` option refers to the latest LTS version of Ubuntu available on Read the Docs,
not the latest LTS version available.
The ``ubuntu-lts-latest`` option refers to the latest Ubuntu LTS version available on Read the Docs,
which may not match with the latest Ubuntu LTS officially released.


.. warning::

Using ``ubuntu-latest-lts`` may break your builds unexpectedly if your project isn't compatible with the latest version when it's updated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using ``ubuntu-latest-lts`` may break your builds unexpectedly if your project isn't compatible with the latest version when it's updated.
Using ``ubuntu-lts-latest`` may break your builds unexpectedly if your project isn't compatible with the newest Ubuntu LTS version released when Read the Docs upgrades to it.

Comment on lines 300 to 301
Each tool has a ``latest`` option available, which refers to the latest version available on Read the Docs,
not the latest version available. Versions are updated at least once every six months.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each tool has a ``latest`` option available, which refers to the latest version available on Read the Docs,
not the latest version available. Versions are updated at least once every six months.
Each tool has a ``latest`` option available, which refers to the latest version available on Read the Docs,
which may not match with the latest version officially released by the tool.
`latest` versions are updated every 6 months to point to the latest version officially released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the at least once part

docs/user/config-file/v2.rst Outdated Show resolved Hide resolved
readthedocs/builds/constants_docker.py Outdated Show resolved Hide resolved
readthedocs/builds/constants_docker.py Show resolved Hide resolved

Each tool has a ``latest`` option available, which refers to the latest version available on Read the Docs,
which may not match the latest version officially released.
Versions and the ``latest`` option are updated at least once every six months to keep up with the latest releases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we documenting what latest currently points to? Seems like that would be useful information, but also a pain to update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was hoping that (alias for the latest version available on Read the Docs) on each tag would be enough given the list of all available versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's basically the same as the first item in the list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last item

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me and I think it's ready to merge.

There are only these two points we may want to keep talking about:

but I think they are not blockers 👍🏼

@stsewd
Copy link
Member Author

stsewd commented Feb 5, 2024

Feel free to merge if you think this should go out with tomorrows deploy!

@ericholscher ericholscher merged commit 2063793 into main Feb 5, 2024
5 checks passed
@ericholscher ericholscher deleted the add-latest-aliases branch February 5, 2024 23:48
shenanigansd added a commit to darbiadev/hermes that referenced this pull request Feb 6, 2024
humitos added a commit that referenced this pull request Feb 6, 2024
humitos added a commit that referenced this pull request Feb 6, 2024
humitos added a commit that referenced this pull request Feb 6, 2024
humitos added a commit that referenced this pull request Feb 6, 2024
shenanigansd added a commit to darbiadev/hermes that referenced this pull request Feb 7, 2024
* Update .readthedocs.yaml to not pin tooling versions

readthedocs/readthedocs.org#11081

Signed-off-by: Bradley Reynolds <[email protected]>

* Strip blank lines

Signed-off-by: Bradley Reynolds <[email protected]>

---------

Signed-off-by: Bradley Reynolds <[email protected]>
humitos added a commit that referenced this pull request Feb 7, 2024
…test` (#11098)

* Build: check for pre-compiled `build.tools` when using `ubuntu-lts-latest`

Related #11081

* Update readthedocs/doc_builder/director.py

Co-authored-by: Santos Gallegos <[email protected]>

---------

Co-authored-by: Santos Gallegos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants