Remove leftovers from django-messages-extends
#10994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep rendering regular one-time Django messages attached to the request, but remove the logic used for sticky/permanent messages from `django-messages-extends`. Closes #10988 Related readthedocs/ext-theme#259
|
I don't understand why we are having those |
|
Huh, yeah I forgot it was even used here. I wouldn't bother addressing anything with the JS, perhaps it's best to just disable eslint in CI? |
agjohnson
approved these changes
Jan 4, 2024
|
Eslint error started happening on #10922, maybe the indentation of the return statement. I've founded useful in the past to catch some errors. |
humitos
added a commit
to readthedocs/ext-theme
that referenced
this pull request
Jan 4, 2024
* Initial comment * Show new notifications statically via Django templates * Refresh the page once the build has finished This temporal hack allows us to show the new notifications from Django templates. The next step here is to implement the notifications properly using Knockout and keep this feature on. * Keep rendering old `Build.error` Render new `Notification` if there are any. Otherwise, render `Build.error`. * Iterate over the right element * Remove debugging * Lint * Remove rendering for `django-messages-extends` Related readthedocs/readthedocs.org#10994 * Remove invalid comment * Build assets
|
I will try to address the eslint error in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep rendering regular one-time Django messages attached to the request, but remove the logic used for sticky/permanent messages from
django-messages-extends.Closes #10988
Related readthedocs/ext-theme#259