-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Refactor all business features into feature reference + change "privacy level" page (Diátaxis) #10007
Docs: Refactor all business features into feature reference + change "privacy level" page (Diátaxis) #10007
Conversation
…ng to landing pages
@ericholscher I'm gonna have a look at the other review feedback you've provided. Would you be able to have a quick look here at the 2 "open questions" in the description ⬆️ ? |
Went over the open questions, and this PR is now open for review 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 💯 Lots of nitpicks, as usual :) Been hanging out with writers for too long.
Read the Docs for Business | ||
-------------------------- | ||
About |com_brand| | ||
================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? I never know if it's going to expand first or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea... could be a good use case for myst, but not sure if they have substitutions heh :) There's a hack to get nested syntax, I think using another substitution or something janky.
Co-authored-by: Eric Holscher <[email protected]>
Co-authored-by: Eric Holscher <[email protected]>
Seems everything is good! I'll leave a comment thread unresolved in case needs attention, but doesn't seem critical to me. |
Nice to get this in wrt other PRs on feature reference and TOC refactoring. |
This refactor does the following:
Open questions:
How do we refer to "landing pages" or "marketing website"? What's the word that we would use in our documentation?"Website" is the best term moving forwards, since we're unifying various landing page experience 👍Should this PR also just jump straight into refactoring the old "About" navigation section into reference? Not seeing any blockers...Doing remaining work in a separate PR because we might want to go into details with the About Read the Docs for Business pageRefs: #9746
📚 Documentation previews 📚
docs
): https://docs--10007.org.readthedocs.build/en/10007/dev
): https://dev--10007.org.readthedocs.build/en/10007/