Duplicate build sends GH PR status, showing failure until the first build finishes #9040
Assignees
Comments
|
Good catch! I think we should probably avoid sending the github notification status when we detect the build is duplicated. This happens at |
humitos
added a commit
that referenced
this issue
Mar 29, 2022
When the exception is an exception we know it does not require communicating the VCS service about its state, we avoid sending the build status to the VCS service. This is currently used to avoid sending a "failure" (red cross) notification when the build is marked as duplicated. In the future, it could also be used when the build is auto-cancelled because a new commit on the same branch was done (see #8961) Closes #9040
humitos
added a commit
that referenced
this issue
Mar 30, 2022
When the exception is an exception we know it does not require communicating the VCS service about its state, we avoid sending the build status to the VCS service. This is currently used to avoid sending a "failure" (red cross) notification when the build is marked as duplicated. In the future, it could also be used when the build is auto-cancelled because a new commit on the same branch was done (see #8961) Closes #9040
Repository owner
moved this from In progress
to Done
in 📍Roadmap
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Details
Expected Result
I expect GH to show "build running" with a link pointing to the first build for that commit
Actual Result
GH shows a failed build in the status result, pointing to the build that failed with
Duplicated build. This is replaced with a ✔️ success after the first build finishes and overwrites the status.The text was updated successfully, but these errors were encountered: