Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose our Embed tools to users again #5207

Closed
4 tasks
ericholscher opened this issue Jan 31, 2019 · 2 comments
Closed
4 tasks

Expose our Embed tools to users again #5207

ericholscher opened this issue Jan 31, 2019 · 2 comments
Labels
Accepted Accepted issue on our roadmap Needed: design decision A core team decision is required

Comments

@ericholscher
Copy link
Member

ericholscher commented Jan 31, 2019

Currently we have some neat functionality with our Embed API & embed JS client. You can see one version of it here:

https://readthedocs.org/projects/docs/tools/embed/

We have some basic docs for this, but it doesn't document the actual REST API:

We should document the actual API, and remove docs around the Sphinx extension, at least. We can work on the Sphinx extension more in the future, but for now I don't think it's quite ready.

Refs #2667 (comment)

Work

  • Modernize and clean up client side code
  • Release client code in proper way
  • Document API
  • Remove unused parts of embed for now, target these pieces as later priority
@ericholscher ericholscher added Design Design or UX/UI related Needed: design decision A core team decision is required and removed Design Design or UX/UI related labels Jan 31, 2019
@agjohnson
Copy link
Contributor

I'm +1 on getting this spruced up for release.

I'd also say we probably need to make our client side javascript more polished and user-friendly. I'd like to do a proper release of the client side JS before we promote the embed stuff, especially if the interface in the client side is going to change. I'd rather avoid supporting backwards compatibility with what is essentially POC level client side code.

That repo has sat idle for 4 years, so I'll take some time to delve into it and see what work is needed as a first step there. It's likely that this could be added to our roadmap for the end of this month or next month though, and would be a good feature to be promoting.

@agjohnson agjohnson added the Accepted Accepted issue on our roadmap label Feb 4, 2019
@humitos
Copy link
Member

humitos commented Sep 15, 2023

We should document the actual API, and remove docs around the Sphinx extension, at least

We already have documented the Embed APIv3 at https://docs.readthedocs.io/en/stable/api/v3.html#embed

I'd also say we probably need to make our client side javascript more polished and user-friendly. I'd like to do a proper release of the client side JS before we promote the embed stuff, especially if the interface in the client side is going to change.

We are re-writing this as an addon now using propper Javascript patterns. We are calling it tooltips addon currently: readthedocs/addons#20

@humitos humitos closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants