-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed API Javascript example not working #2667
Comments
On the NOTE it says that they are already loaded but I'm getting a 404 on http://docs.readthedocs.io/static/css/public.css |
The embed stuff is half baked. We should consolidate this until we have something that is production ready. |
I think the urls are:
And on rtd:
But doesn't look like this is implemented. |
I guess we can remove that documentation till we have something working, the embed endpoint was removed #4768. Actually, it should just be updated, but we need to modify the ext: The embebed logic comes from https://github.com/rtfd/readthedocs-ext/blob/af0f42aa1227551b0849605d9935d102f130ce8b/readthedocsext/embed/views.py#L35 and it's mounted on the v1 endpoint https://github.com/rtfd/readthedocs.org/blob/b170de972be8dfe99318ab7533a72c8bf6ec32a1/readthedocs/urls.py#L117-L121 But the sphinx-ext is fetching from the v2 endpoint (that got removed bs it wasn't working). The v1 endpoint works https://readthedocs.org/api/v1/embed/?project=requests&doc=index§ion=User%20Guide |
Should we update the sphinx-ext? or should we mount the embed api on the v2 endpoint? or remove the feature? |
Yea, we should remove this from the docs, and just expose the REST API & JS framework for now. |
At http://docs.readthedocs.io/en/latest/embed.html#javascript there is a real example that doesn't work because it's not able to load the css and js file because it's using
http://localhost:5555/
urls.What are the correct ones?
The text was updated successfully, but these errors were encountered: