Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build list to include an alert state #4036

Closed
agjohnson opened this issue Apr 27, 2018 · 1 comment · Fixed by #5222
Closed

Update build list to include an alert state #4036

agjohnson opened this issue Apr 27, 2018 · 1 comment · Fixed by #5222
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone
3.4

Comments

@agjohnson
Copy link
Contributor

As raised in #4018, a better UI for a queue backup would be to show the affected builds in an alert state:

  • Show an alert state on each hanging build in the build list if build.state == triggered and build.date > 5m ago. No need for redis here
  • Alert state should be very minimal, a FA icon -- ie https://fontawesome.com/icons/exclamation-triangle?style=solid
  • Perhaps mouse over on icon shows a brief message "This build is still waiting to be built"
  • Link still goes to detail page
  • There should be a warning box (using the standard notification pattern!) that says something along the lines of "This build has not started yet. This can be due to heavy build volume or to a problem with Read the Docs. If the problem persists, contact us"
@agjohnson agjohnson added the Improvement Minor improvement to code label Apr 27, 2018
@agjohnson agjohnson added this to the 2.5 milestone Apr 27, 2018
@agjohnson agjohnson added the Accepted Accepted issue on our roadmap label Jun 8, 2018
@agjohnson agjohnson modified the milestones: 3.2, 3.4 Jan 25, 2019
@saadmk11
Copy link
Member

saadmk11 commented Feb 1, 2019

Where should the warning box be on the list page or the detail page?

@saadmk11 saadmk11 mentioned this issue Feb 3, 2019
Merged
agjohnson pushed a commit that referenced this issue Feb 20, 2019
@saadmk11 @agjohnson
#4036 Updated build list to include an alert state (#5222)
3218c80 
* Updated build list to include an alert state

* Docstring issue fixed.

* Template filter name changed.

* Logic Moved to Models

* Lint issue Fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
3.4
Development

Successfully merging a pull request may close this issue.

#4036 Updated build list to include an alert state saadmk11/readthedocs.org
2 participants
@agjohnson @saadmk11