Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split requirements/pip.txt for LocalBuildEnvironment and RTD specific #3757

Closed
4 tasks
humitos opened this issue Mar 9, 2018 · 4 comments
Closed
4 tasks
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone

Comments

@humitos
Copy link
Member

humitos commented Mar 9, 2018

Now, we have a big requirements/pip.txt that covers two big things:

  • RTD project specific requirements (django, requests, docker, etc)
  • local builds for user's documentation (mkdocs, etc) --these are used when building documentation without docker

We want to remove the dependencies for building the docs outside Docker from the pip.txt file, so to accomplish this issue we need:

  • create a new file requirements/local-docs-build.txt
  • take a look at that list and classify each of the requirements on one of these points
  • move not RTD specific requirements to the new file
  • QA/test manually by creating the proper venvs with the proper requirements and build random project's documentation

Ref: #2916 (comment)

@humitos humitos added the Improvement Minor improvement to code label Mar 9, 2018
@Jigar3
Copy link
Contributor

Jigar3 commented Mar 9, 2018

I want to solve this issue. Can you help me get started

@stsewd
Copy link
Member

stsewd commented Mar 10, 2018

@Jigar3 I think there is a very good description about the issue and the needed steps, there is something specific that you need help with?

@RichardLitt
Copy link
Member

@Jigar3 I think that @rajujha373 has taken a stab at it. Look at his solution; it should help you see how you could have done it. For now, I think that you don't need to help solve this one. I would suggest looking at some other issues which are currently open! Please always feel free to ask questions, but know that we are mostly volunteer run, and we may expect you to tinker around a bit sometimes. :)

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@humitos humitos added this to the Refactoring milestone Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

4 participants