Fix project variable

readthedocs · Mar 13, 2018 · c6b5763 · c6b5763
1 parent 497ee67
commit c6b5763
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/readthedocs/projects/forms.py b/readthedocs/projects/forms.py
@@ -177,7 +177,7 @@ class Meta(object):
 
     def clean_language(self):
         language = self.cleaned_data['language']
-        project = self.data['project']
+        project = self.instance
         if project:
             if project.translations.filter(language=language).exists():
                 msg = 'There is a translation for the "{lang}" language.'

diff --git a/readthedocs/rtd_tests/tests/test_project_forms.py b/readthedocs/rtd_tests/tests/test_project_forms.py
@@ -202,23 +202,27 @@ def test_cant_change_language_to_translation_lang(self):
         self.project_a_es.save()
 
         # Parent project tries to change lang
-        form = ProjectExtraForm({
-            'project': self.project_a_es,
-            'documentation_type': 'sphinx',
-            'language': 'en',
-        })
+        form = ProjectExtraForm(
+            {
+                'documentation_type': 'sphinx',
+                'language': 'en',
+            },
+            instance=self.project_a_es
+        )
         self.assertFalse(form.is_valid())
         self.assertIn(
             'There is a translation for the',
             ''.join(form.errors['language'])
         )
 
         # Translation tries to change lang
-        form = ProjectExtraForm({
-            'project': self.project_b_en,
-            'documentation_type': 'sphinx',
-            'language': 'es',
-        })
+        form = ProjectExtraForm(
+            {
+                'documentation_type': 'sphinx',
+                'language': 'es',
+            },
+            instance=self.project_b_en
+        )
         self.assertFalse(form.is_valid())
         self.assertIn(
             'The translation can not have the same language',