Skip to content

Commit

Permalink
Remove build queue length warning on build list page
Browse files Browse the repository at this point in the history
This piece of UI was never updated to fit somewhere more cohesive in the UI and
I feel is a strange thing to expose directly to users. I think a better
application for this is in an eventual status page. A status page is not a
priority atm though.
  • Loading branch information
agjohnson committed Apr 25, 2018
1 parent c3af6ec commit 4ab5f75
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
8 changes: 0 additions & 8 deletions readthedocs/builds/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
from readthedocs.core.utils import trigger_build
from readthedocs.projects.models import Project

from redis import Redis, ConnectionError


log = logging.getLogger(__name__)

Expand Down Expand Up @@ -67,12 +65,6 @@ def get_context_data(self, **kwargs):
context['versions'] = Version.objects.public(user=self.request.user, project=self.project)
context['build_qs'] = self.get_queryset()

try:
redis = Redis.from_url(settings.BROKER_URL)
context['queue_length'] = redis.llen('celery')
except ConnectionError:
context['queue_length'] = None

return context


Expand Down
12 changes: 0 additions & 12 deletions readthedocs/templates/builds/build_list.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,6 @@
{% block content %}


<!-- BEGIN queue depth warning -->
{% if queue_length > 10 %}
<div>
<p>
{% blocktrans with queue_length as queue_length %}
Whoa! The build queue is {{ queue_length }} tasks long, new builds may take a while.
{% endblocktrans %}
</p>
</div>
{% endif %}


<div id="build_list">

{% autopaginate build_qs 15 %}
Expand Down

0 comments on commit 4ab5f75

Please sign in to comment.