Merge pull request #4805 from rtfd/humitos/integrations/handle-error-…

…codes Handle 401, 403 and 404 status codes when hitting GitHub for webhook
readthedocs · Jan 10, 2019 · 392ff56 · 392ff56
2 parents 78e5b7a + 2ae1c26
commit 392ff56
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/readthedocs/oauth/services/github.py b/readthedocs/oauth/services/github.py
@@ -207,6 +207,14 @@ def setup_webhook(self, project):
                 log.info('GitHub webhook creation successful for project: %s',
                          project)
                 return (True, resp)
+
+            if resp.status_code in [401, 403, 404]:
+                log.info(
+                    'GitHub project does not exist or user does not have '
+                    'permissions: project=%s',
+                    project,
+                )
+                return (False, resp)
         # Catch exceptions with request or deserializing JSON
         except (RequestException, ValueError):
             log.exception(