CSS: clean up some classes #74
Conversation
|
It might be worth testing IE/Edge for this, as the attributes on the svg element might be required for IE compatibility. IE support for svg was bad for a long time, and scaling issues are a known problem. |
There were some values hard-coded in the html attributes, but we already were setting them in our css. Also, search__backdrop was basically the same as search__outer__wrapper
|
According to this thing it looks good https://www.browserling.com/browse/win/7/ie/11/https%3A%2F%2Freadthedocs-sphinx-search--74.org.readthedocs.build%2Fen%2F74%2F I may need to boot a windows VM to double check, don't think there is a headless driver for IE |
|
We also have a OSS account at saucelabs that i commonly use for theme development, I can share the creds with you |
|
@agjohnson yes please! |
|
@agjohnson looks like everything works as expected. Noticed the extension doesn't work at all on IE 10, not sure if we want to support it though. |
|
Can you post a screen grab or something for ie10? i remember there were some issues, but it should work. We've talked about dropping support for ie10, but don't have an official position yet. Last I checked, there was still a non-zero amount of ie10 traffic -- which when you're talking about 20M monthly pageviews, is still probably ~100k monthly pageviews. I've lost where we had the conversation last |
This UI is the same, search doesn't work, it throws an exception in the js code, so when you search nothing happens, and you can't even close the modal
the docs.rtfd.io site has definitely problems with the svg image :D
|
There were some values hard-coded in the html attributes,
but we already were setting them in our css.
Also, search__backdrop was basically the same as search__outer__wrapper
You can see it working at https://readthedocs-sphinx-search.readthedocs.io/en/clean-up-css/?rtd_search=search