Put ad free status into READTHEDOCS_DATA for sphinx #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
reviewed
Jul 6, 2018
There was a problem hiding this comment.
I feel like this should probably come via the Footer API request or similar, because changing it won't trigger a rebuild and could end up out of date. Though we probably don't want to have the Ad request wait until the footer API call has responded, so a bit chicken & egg, and this is probably the best solution.
| @@ -11,6 +11,7 @@ var READTHEDOCS_DATA = { | |||
| source_suffix: "{{ source_suffix }}", | |||
| api_host: "{{ api_host }}", | |||
| commit: "{{ commit }}", | |||
| ad_free: {% if ad_free %}true{% else %}false{% endif %}, | |||
There was a problem hiding this comment.
Should this take into account gold status as well, since that has the same effect?
ericholscher
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for readthedocs/readthedocs.org#4329 to work for Sphinx projects