Skip to content

Commit

Permalink
asdf: update asdf and all its plugins
Browse files Browse the repository at this point in the history
This will allow us to be smarter about _when to reshim_.

With this update, it will be handled automatically by `asdf` and we won't
require a custom chunk of code in our application:

https://github.com/readthedocs/readthedocs.org/blob/a5965129c61b9bcdff2f2098ff7ce7f8c093dc74/readthedocs/doc_builder/director.py#L373-L386

Currently, multi-lines commands that install something with `pip` and immediate
after that, inside the multi-line command try to use the executable installed,
fail because it's not automatically reshimed.

By reshiming at `asdf` level, this case will be solved.

Related: readthedocs/readthedocs.org#9150 (comment)
Related: asdf-community/asdf-python#136
  • Loading branch information
humitos committed Mar 9, 2023
1 parent d962534 commit ecef0a2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Read the Docs - Environment base
FROM ubuntu:22.04
LABEL mantainer="Read the Docs <[email protected]>"
LABEL version="ubuntu-22.04-2022.03.15"
LABEL version="ubuntu-22.04-2023.03.09"

ENV DEBIAN_FRONTEND noninteractive
ENV LANG C.UTF-8
Expand Down Expand Up @@ -112,7 +112,7 @@ USER docs
WORKDIR /home/docs

# Install asdf
RUN git clone https://github.com/asdf-vm/asdf.git ~/.asdf --depth 1 --branch v0.9.0
RUN git clone https://github.com/asdf-vm/asdf.git ~/.asdf --depth 1 --branch v0.11.2
RUN echo ". /home/docs/.asdf/asdf.sh" >> /home/docs/.bashrc
RUN echo ". /home/docs/.asdf/completions/asdf.bash" >> /home/docs/.bashrc

Expand Down

0 comments on commit ecef0a2

Please sign in to comment.