Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close/cancel button to all modals #519

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add close/cancel button to all modals #519

wants to merge 3 commits into from

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 4, 2024

The only modal that I didn't put a button on is

<div class="ui mini modal" data-modal-id="invite-owner">
<div class="header">{% trans "Invite organization owner" %}</div>
<div class="content">
<form class="ui form"
method="post"
action="{% url "organization_owner_add" organization.slug %}">
{% csrf_token %}
{{ form|crispy }}
<input class="ui button" type="submit" value="{% trans "Invite owner" %}">
</form>
</div>
</div>
{% endif %}

since it has the form as content, doesn't have an "actions" div.

Closes #510

@stsewd stsewd requested a review from a team as a code owner November 4, 2024 19:08
@stsewd stsewd requested a review from agjohnson November 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modals are missing a cancel/close button
1 participant