Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing notification template blocks for user, project, organization notifications #260

Closed
agjohnson opened this issue Jan 9, 2024 · 3 comments · Fixed by #261
Closed

Add missing notification template blocks for user, project, organization notifications #260

agjohnson opened this issue Jan 9, 2024 · 3 comments · Fixed by #261
Assignees
@humitos

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Jan 9, 2024 •
edited
Loading

From the deploy today, it seems these were not ported to the new dashboard.
@agjohnson agjohnson converted this from a draft issue Jan 9, 2024
@humitos
Copy link
Member

humitos commented Jan 10, 2024

Template blocks on old dashboard that we need to migrate to ext-theme:

humitos added a commit to readthedocs/readthedocs.org that referenced this issue Jan 10, 2024
@humitos
Notifications: render Organization notifications on details page
35725cc 
This work was missed when implementing the new notification system.

Related readthedocs/ext-theme#260
@humitos humitos mentioned this issue Jan 10, 2024
Merged
@humitos
Copy link
Member

humitos commented Jan 10, 2024

Organization: ??? -- I think this was not implemented there.

I implemented this at readthedocs/readthedocs.org#11023

@humitos humitos moved this from Planned to In progress in 📍Roadmap Jan 10, 2024
@agjohnson
Copy link
Contributor Author

We might have missed opening an issue for the organization notifications, I remember discussing it at some point.

For notifications for user/project/orgs on the new dashboard, you can copy the previous template HTML structure for the message-extends messages. I believe this was removed in that last PR.

humitos added a commit to readthedocs/readthedocs.org that referenced this issue Jan 11, 2024
@humitos
Notifications: render Organization notifications on details page (#…
74fa96c 
…11023)

This work was missed when implementing the new notification system.

Related readthedocs/ext-theme#260
humitos added a commit that referenced this issue Jan 11, 2024
@humitos
Notifications: show attached to User, Project and Organization
3e31aa6 
Render notifications attached to these objects.
This is the first pass of this work and there are some things we need to make
decisions and improve.

- Where (what pages) these notifications should render?
- How "global" they should be considered?

Note we are rendering these notifications in the template for now,
but in the future they will be rendered using the APIv3: #259

Closes #260
@humitos humitos mentioned this issue Jan 11, 2024
Merged
@humitos humitos moved this from In progress to Needs review in 📍Roadmap Jan 15, 2024
humitos added a commit that referenced this issue Jan 18, 2024
@humitos @agjohnson
Notifications: show attached to User, Project and Organization (#…
df4192b 
…261)

* Notifications: show attached to `User`, `Project` and `Organization`

Render notifications attached to these objects.
This is the first pass of this work and there are some things we need to make
decisions and improve.

- Where (what pages) these notifications should render?
- How "global" they should be considered?

Note we are rendering these notifications in the template for now,
but in the future they will be rendered using the APIv3: #259

Closes #260

* Render notifications before project/organization header

* Apply suggestions from code review

Co-authored-by: Anthony <[email protected]>

---------

Co-authored-by: Anthony <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
None yet
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notifications: show attached to User, Project and Organization readthedocs/ext-theme
2 participants
@humitos @agjohnson