Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not track support #2

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Do not track support #2

merged 1 commit into from
Sep 14, 2018

Conversation

davidfischer
Copy link
Collaborator

  • Do not track support as the EFF specifies
  • This is optional and disabled by default. This should be disabled by default because there's more to complying with DNT than what's contained in the server. It relies on web server config and more. Use the Django setting ADSERVER_DO_NOT_TRACK to enable it.
  • This is very similar to what was enabled for RTD itself

ericholscher
ericholscher approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. This doesn't actually change our app at all right? It just adds the files being served.

@davidfischer
Copy link
Collaborator Author

This doesn't actually change our app at all right? It just adds the files being served.

Correct

@davidfischer davidfischer merged commit db17dbd into master Sep 14, 2018
@davidfischer davidfischer deleted the davidfischer/dnt-support branch September 14, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfischer @ericholscher