Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap the flyout header. #440

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't wrap the flyout header. #440

wants to merge 1 commit into from

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 19, 2024

This makes it so the version doesn't overflow as badly:

Before

Screenshot 2024-11-19 at 2 30 24 PM

After

Screenshot 2024-11-19 at 2 30 12 PM

This makes it so the version doesn't overflow as badly:
@ericholscher ericholscher requested review from humitos and a team as code owners November 19, 2024 22:37
@agjohnson
Copy link
Contributor

agjohnson commented Nov 20, 2024

Unfortunately, both options have issues. I don't think we should shrink the flex grid down without addressing content widths of the labels

While at least it doesn't appear under the logo, without flex grid wrapping the flyout content becomes scrollable and the long strings now wrap oddly and can look worse with icons:

image
image
image

We should truncate the text to fix this: https://css-tricks.com/flexbox-truncated-text/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants