Fix weird search behaviour #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderle
force-pushed
the
fix-weird-search-behaviour
branch
from
adda1d4 to
f63239d
Compare
humitos
reviewed
Aug 8, 2024
Comment on lines
+629
to
630
| this.hideRecentSearches = false; | ||
| debounce(func, CLEAR_RESULTS_DELAY)(); |
There was a problem hiding this comment.
This could confuse users a little bit, since we will show the recent search when we have less than MIN_CHARACTERS_QUERY. I think we should show recent search when the input field is completely empty, instead (e.g. query.length === 0)
There was a problem hiding this comment.
Hm, I've tried this, but felt the behaviour implemented here felt a bit more natural. Have you tried both options? In any case let me know if you want me to change it, no problem at all.
There was a problem hiding this comment.
I just tested it locally as-is and I think it's fine for now. We can change this behavior in the future if we feel it doesn't work well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358
Fixes #357