Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout: hide "current version" for single version projects #97

Closed
humitos opened this issue Aug 30, 2023 · 2 comments · Fixed by #143
Closed

Flyout: hide "current version" for single version projects #97

humitos opened this issue Aug 30, 2023 · 2 comments · Fixed by #143
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Aug 30, 2023

Currently we are showing the v: <default version> (e.g. v: latest) in the flyout when it's closed for "single version" projects. Now that we have the Read the Docs logo on it, we should probably remove the v: latest from here and only show the logo when it's a single version project.

Screenshot_2023-08-30_12-13-24

@humitos humitos added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Aug 30, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Aug 30, 2023
@agjohnson
Copy link
Contributor

Also, it might be good to consider what we might want to change with the flyout before we optimize what we have there now. We've started with the current flyout implementation, but we've also thrown around a lot of ideas about what we might put in the collapsed/expanded versions of the flyout menu if we were designing it today.

@humitos
Copy link
Member Author

humitos commented Sep 1, 2023

Yeah, this issue may be a non-issue for the current flyout and something to consider in the redesign of it.

I'm not sure what we did in the old version. Maybe we just need to copy the logic from there if it's different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants