-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix endoint slash #231
Fix endoint slash #231
Conversation
The URLs sent to the API contained a slash too much: Example for FreshRSS: ``` "POST //api/greader.php/reader/api/0/edit-tag HTTP/1.1" 200 2 "-" "okhttp/4.12.0" "GET //api/greader.php/reader/api/0/tag/list?output=json HTTP/1.1" 200 654 "-" "okhttp/4.12.0" ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #231 +/- ##
==========================================
Coverage 21.43% 21.43%
Complexity 441 441
==========================================
Files 168 168
Lines 8935 8935
Branches 1397 1397
==========================================
Hits 1915 1915
Misses 6905 6905
Partials 115 115 ☔ View full report in Codecov by Sentry. |
Thanks for pointing this! However I think we should fix account url slash duplication earlier than in Could you replace your solution in |
Done |
The broken CI test does not seem to be due to my fix |
Oh okay so thank you for the fix but I must have explained it wrong 😅. I was talking about modifying directly the endpoint string in We can ignore the CI as it seems to be a packaging error which appears sometimes and could be related to not enough memory for Gradle. |
OK. Something like that? |
Yes perfect, thanks for that! |
The URLs sent to the API contained a slash too much:
Example for FreshRSS: