Fix getting sinceId after last items call in FeverDataSource

readrops · Aug 14, 2024 · dd98c7b · dd98c7b
1 parent 7b39203
commit dd98c7b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/api/src/main/java/com/readrops/api/services/fever/FeverDataSource.kt b/api/src/main/java/com/readrops/api/services/fever/FeverDataSource.kt
@@ -82,7 +82,7 @@ class FeverDataSource(private val service: FeverService) {
                             }
 
                             sinceId = if (items.isNotEmpty()) {
-                                items.first().remoteId!!.toLong()
+                                items.maxOfOrNull { it.remoteId!!.toLong() }!!
                             } else {
                                 localSinceId.toLong()
                             }

diff --git a/api/src/test/java/com/readrops/api/services/fever/FeverDataSourceTest.kt b/api/src/test/java/com/readrops/api/services/fever/FeverDataSourceTest.kt
@@ -157,6 +157,7 @@ class FeverDataSourceTest : KoinTest {
         assertEquals(6, result.starredIds.size)
         assertEquals(10, result.items.size)
         assertEquals(10, result.items.size)
+        assertEquals(1564058340320135, result.sinceId)
 
         assertEquals("1564058340320135", firstMaxId)
         assertEquals("6", secondMaxId)
@@ -229,6 +230,7 @@ class FeverDataSourceTest : KoinTest {
         assertEquals(6, result.unreadIds.size)
         assertEquals(6, result.starredIds.size)
         assertEquals(10, result.items.size)
+        assertEquals(10, result.sinceId)
 
         assertEquals("1", firstLastSinceId)
         assertEquals("5", secondLastSinceId)