Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint): disabling default exports in ESM libraries #765

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat(eslint): disabling default exports in ESM libraries #765

merged 2 commits into from
Oct 31, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Oct 31, 2023

🧰 Changes

In libraries that support CJS and ESM having a default export along with exported types completely breaks CJS handling so we're going to start disabling default exports in ESM libraries we ship.

@erunion erunion added the enhancement New feature or request label Oct 31, 2023
@erunion erunion requested a review from kanadgupta October 31, 2023 17:49
kanadgupta
kanadgupta approved these changes Oct 31, 2023
View reviewed changes
packages/eslint-config/esm.js Outdated Show resolved Hide resolved
@erunion erunion merged commit c4c3bc9 into main Oct 31, 2023
2 checks passed
@erunion erunion deleted the feat/no-default-exports branch October 31, 2023 17:54
@erunion erunion mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta kanadgupta approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @kanadgupta