feat(eslint/esm): enable more ESM rules #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This PR enables two rules in our ESM config:
unicorn/prefer-module— this came up as a result of fix: don't use module oas-to-har#243 — this rule will prevent a variety of Node/CommonJS usage patterns, such as__dirname,require, andmodule.exports(this rule slaps)node/no-extraneous-import— basically the ESM equivalent ofnode/no-extraneous-requireThere are a slew of suggested ESM configuration options listed in this gist, but I decided to only enable these ones for now.
🧬 QA & Testing
Have I mentioned that the
eslint-define-configtypes that we have in this repo are extremely handy?