quote JS object properties consistently #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses an issue where Prettier would auto-convert unicode keys back to emoji, which caused breakage in IE11 (See: [api-explorer#e357013](readmeio/api-explorer@e357013))
erunion
reviewed
May 8, 2020
erunion
approved these changes
May 8, 2020
|
Since this has the potential to cause a large diff in some of our projects, I'm publishing this to v2.2.0. |
|
k let me know how I can be of help integrating this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our Prettier config to address an issue where
npm test -- -uwould auto-convert unicode strings back to emojis in our scripts, which caused breakage in IE11 (See: api-explorer#e357013) Alternately, we could probably override this directly in the Explorer somehow; no opinion on which'd be better...