Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: including our standard prettier config so it can be shared #41

Merged
merged 2 commits into from
Jan 28, 2020
Merged

feat: including our standard prettier config so it can be shared #41

merged 2 commits into from
Jan 28, 2020

Conversation

erunion
Copy link
Member

@erunion erunion commented Jan 28, 2020

Having this in our core ESLint config will allow us to stop requiring .pretteirrc files in every repository.

@erunion erunion added the enhancement New feature or request label Jan 28, 2020
@erunion erunion merged commit 3ec3f0b into master Jan 28, 2020
@erunion erunion deleted the feat/shared-prettier-config branch January 28, 2020 20:30
@domharrington
Copy link
Member

Woah! 🙌

@erunion
Copy link
Member Author

erunion commented Jan 29, 2020

Turns out this doesn't fully work yet! Running prettier --fix in a repo with this update and no .prettierrc will run Prettier with all the defaults. I'm tinkering around with some postinstall ideas to automatically plop a .prettierrc in repos that pull this package in, but for the moment we can't kill that file everywhere just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @domharrington