chore: tsconfig cleanup #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
commented
Sep 15, 2023
| @@ -2,20 +2,14 @@ | |||
| "compilerOptions": { | |||
| "allowJs": true, | |||
| "baseUrl": "./src", | |||
| "downlevelIteration": true, | |||
| "esModuleInterop": true, | |||
There was a problem hiding this comment.
this flag is enabled by default now that we're on NodeNext
| "experimentalDecorators": true, | ||
| "forceConsistentCasingInFileNames": true, |
There was a problem hiding this comment.
this flag is enabled by default
Comment on lines
-12
to
-14
| "paths": { | ||
| "editor": [".sink.d.ts"] | ||
| }, |
erunion
reviewed
Sep 15, 2023
| "module": "NodeNext", | ||
| "outDir": "dist/", | ||
| "paths": { | ||
| "editor": [".sink.d.ts"] | ||
| }, | ||
| "resolveJsonModule": true, |
There was a problem hiding this comment.
Are we importing JSON files anywhere not in a unit test?
There was a problem hiding this comment.
yeah we use our package.json file in a bunch of places
erunion
approved these changes
Sep 15, 2023
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Cleans up and modernizes our
tsconfig!🧬 QA & Testing
If the build passes across the board we should be good to go.