Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): use shrinkwrap instead of lockfile #803

Merged
merged 7 commits into from
Apr 19, 2023
Merged

fix(npm): use shrinkwrap instead of lockfile #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d86eac3
fix(deps): bump `oas` (and others)
kanadgupta Apr 19, 2023
312826e
chore(npm): use shrinkwrap instead of lockfile
kanadgupta Apr 19, 2023
2774a8f
fix: prettier
kanadgupta Apr 19, 2023
14ce39a
fix: add shrinkwrap to release assets
kanadgupta Apr 19, 2023
6b64a05
Merge branch 'next' into shrinkwrap
kanadgupta Apr 19, 2023
da7d3a8
chore(prettier): ignore shrinkwrap
kanadgupta Apr 19, 2023
7fd5e81
Revert "fix: prettier"
kanadgupta Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ __tests__/__fixtures__/invalid-json/yikes.json
CHANGELOG.md
coverage/
dist/
npm-shrinkwrap.json
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL that prettier ignores package-lock.json by default 🙄

2 changes: 1 addition & 1 deletion .releaserc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ plugins:
- [
'@semantic-release/git',
{
assets: ['action.yml', 'CHANGELOG.md', 'package.json', 'package-lock.json'],
assets: ['action.yml', 'CHANGELOG.md', 'package.json', 'npm-shrinkwrap.json'],
message: "build(release): 🚀 v${nextRelease.version} 🦉\n\n${nextRelease.notes}\n[skip ci]",
},
]
Expand Down
0 package-lock.json → npm-shrinkwrap.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I swear I thought that NPM published package-lock.json to the registry unless you excluded it in .npmignore but it's definitely not there. https://www.npmjs.com/package/rdme?activeTab=code

If you install new or update existing packages does that recreate package-lock or does it bump the shrinkwrap?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It updates the shrinkwrap1! If both files (package-lock and npm-shrinkwrap) are present, the latter takes precedence and the former is ignored: https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json#package-lockjson-vs-npm-shrinkwrapjson

Footnotes

  1. I confirmed this locally! ↩

File renamed without changes.