Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): surface Warning response headers #721

Merged
merged 3 commits into from
Dec 20, 2022
Merged

feat(api): surface Warning response headers #721

merged 3 commits into from
Dec 20, 2022

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Dec 20, 2022 •
edited
Loading

🧰 Changes

As we start surfacing Warning headers from the ReadMe API, we can now surface them in our formatted warning output.

🧬 QA & Testing

Don't have an example API request but do tests pass?

@kanadgupta kanadgupta marked this pull request as ready for review December 20, 2022 22:00
@kanadgupta kanadgupta added the enhancement New feature or request label Dec 20, 2022
erunion
erunion approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:hellyea: :nice: :nice-rgb: :sick:

@kanadgupta kanadgupta merged commit a210754 into main Dec 20, 2022
@kanadgupta kanadgupta deleted the feat/api-warnings branch December 20, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

@Dashron Dashron Awaiting requested review from Dashron

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @erunion