feat(openapi): exposing our spec conversion tooling to a new :convert command
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
kanadgupta
requested changes
Dec 19, 2022
Co-authored-by: Kanad Gupta <[email protected]>
Co-authored-by: Kanad Gupta <[email protected]>
erunion
commented
Dec 19, 2022
kanadgupta
approved these changes
Dec 19, 2022
| this.definitionVersion = definitionVersion.version; | ||
| const parsedBundledSpec = JSON.parse(bundledSpec); | ||
| const parsedPreparedSpec = JSON.parse(preparedSpec); |
There was a problem hiding this comment.
this would have been hilarious if it was called parsedStringifiedSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This exposes our internal Swagger and Postman spec conversion work that we do into a new
openapi:convertcommand as it may be be useful to have outside of the context of regular spec uploading and validation.It works the same as our other
openapi:*commands and prompts you for specs, accepts a working directory, and has an--outargument for storing the converted spec.🧬 QA & Testing